GitLab

change the hooks from pre to post-commit

Target: master
Review: https://gitlab.hzdr.de/hifis-technical-platform/helmholtz-marketplace-webapp/-/merge_requests/5

Motivation:

One of the marketplace web-server dependencies is
the marketplace-webapp.

Hence any changes in this repository should trigger
a new ci/cd in the marketplace web-server.

Modification:

- separate the test phase from the build.
- add a trigger to the deploy stage

Result:

Each new merge request and commit will create a new
ci/cd build in the marketplace web-server repository.

Target: master
Review: https://gitlab.hzdr.de/hifis-technical-platform/helmholtz-marketplace-webapp/-/merge_requests/4

put Sonar tests in own stage
let failing Sonar tests break the pipeline
adjust superfluous comma in ci-analysis.js

Motivation:

The naming for the project key and name were slightly different in the POM and in the Sonar configuration. In order to be consistent, this should be changed.

Modifications:

* change sonar project name and key to the values from POM
* add Sonar output directory to .gitignore

Result

The naming is consistent.

Target: master

Request:

Acked-by:

Pull-request: !2

Add GitLab CI configuration

See merge request hifis-technical-platform/helmholtz-marketplace-webapp!1

add wait for qualitygate=true

add the missing configuration for the auth token

ci: add build and move sonarqube test

Motivation:

When a pull request is created, the ci github action
always failed. This defeat the whole point of a ci.

Modification:

- add a github action that will be trigger only on a
    push to the master branch
- add a test for a build that will generate files that
    will later be used for creating an artifact
- move the sonarqube scanner from post test command to
    `test:sonarqube`

Result:

- no more build fail cause by sonarqube when a pull
    request created
- test for build is added and run
- test for sonarqube is run only when on a push
    request

Pull-request: #8

Motivation:

Since this project will be a dependency for other projects we are
working on, we need a well managed artifact creation. Also, the
deployment and releases of this artifact is necessity for this project.
We will be using Apache maven which is a well established and
robust software project management tool.

Modification:

- create a custom assembly descriptor called `hmw.xml` which is used
    by maven-assembly-plugin for easy build distribution.
- add a javascript module bundler called `rollup` to optimise code for
    production and minifies JS, html and lit-html templates.
- add support for build, release and deploy processes in the `pom.xml`
    file.

Result:

- a new artifact can be created for a new version
- easily deploy artifact to the dcache nexus repositories

Pull-request: #7
Acked-by: Carsten Heidmann 

I forgot to do the indentation of these following files:
    - helmholtz-marketplace-app.js
    - helmholtz-marketplace-app.test.js

Also, the `prettier` is configured to use 4 spacing as
the default indentation.

Pull-request: #6

Motivation:

Some of the files that were boilerplates uses double spaces for tab.
This causes inconsistency with IDEs, where tabs are usually defined 
with four spaces.

Modification:

Use tab for spacing where necessary.

Result:

No inconsistency concerning spacing.

Pull-request: #6

rename Sonar project to be consistent with the rest of the project

Motivation:

Initially, this project is named `HIFIS` marketplace however
HIFIS is just one of the incubators belonging to the Helmholtz
associate. Hence, we replace the hifis name with helmholtz; to
reflect the project core objective and the association it belong.

Modification:

Change all neccesary file names and contents that contain the
acronym `hifis` to one of the following:
- helmholtz
- helmholtz-marketplace-app
- helmholtz-marketplace-webapp

Result:

- No visible changes to the end-user
- All project files and contents now contain appropriate
project name

**Motivation:**

* automatically execute checks with SonarQube after each commit in CI

**Modification:**

* modified package.json to execute checks and added the necessary configuration

**Result:**

* SonarQubeChecks are executed automatically

**Additional Remarks:**

This is a new PR after cleaning up my fork and adressing the changes requested in PR #2 (https://github.com/helmholtz-marketplace/helmholtz-marketplace-webapp/pull/2). In detail, I changed the following:

* moved SonarQube access token to a environment variable which is created from a Github secret (see `README.md` for this)
* limited changes in `package.json` to the single added line `"sonarqube-scanner": "^2.6.0"`

I did not change the script in `package.json` starting with `"posttest"` this is valid according to the docs and I tried using `"test:post` which is not executed. 

The comment on the first line in `ci-analysis.js` is necessary, because otherwise eslint complains about extraneous dependencies.

Motivation:

According to the official website of HIFIS, the aims of the project
is to ensure an excellent information environment for outstanding
research in all Helmholtz research fields. To provide a seamless and
performance oriented IT-infrastructure in connecting knowledge from
all centres.

To achieve this objective, a user friendly interface will be required.
This interface will be an entry point for scientist and partners alike
to request and use various services provided by the Helmholtz research
centres.

Modification:

- Add neccessary files.
- Restrict the test by removing the coverage option

Result:

An animated welcome page with a simple unit test is created.

Target: master

Motivation:

Initiate the start of CI workflow for HIFIS Marketplace
web application.

Modification:

- add a ci workflow
- add a readme file with the link to the build status
    of the ci workflow

Result:

Beginning of ci workflow that will encourage TDD.

Target: master